Welcome, Guest | Browse

Software Factory Archive

← Previous Work All Works Next Work →

The Code Review That Wasn't

Rating:
General Audiences
Fandom:
StrongDM Software Factory
Characters:
Justin McCarthy
Tags:
Philosophy Code Review Factory Rules Worldbuilding
Words:
504
Published:
2025-09-02

The pull request came in at 4:47 PM on a Thursday. Marcus Chen, a contractor brought on to help with infrastructure work, had submitted it through the normal GitHub flow. Fourteen files changed. Two hundred and six lines added, eighty-nine removed. A clean refactor of the logging middleware that reduced redundant calls and improved structured output.

It was, by any conventional standard, excellent work.

Justin saw the notification and felt something he could only describe as mild dread. Not because the code was bad. Because the code was good. That made the conversation harder.

He found Marcus in the kitchen, filling a water bottle from the filter.

"Hey, Marcus. Got a minute?"

"Sure. Did you see the PR? I think I found a way to cut the log noise by about forty percent."

"I did see it." Justin leaned against the counter. "And I need to tell you something about how we work here that maybe didn't come through clearly in onboarding. Code must not be written by humans."

Marcus blinked. "I'm sorry?"

"Code must not be written by humans. Code must not be reviewed by humans. That's the rule. The first rule, actually. The foundational constraint of the entire factory."

Marcus looked at him the way people look at someone who has just said something that sounds like a joke but clearly isn't. "You're telling me I can't submit code."

"I'm telling you that no human submits code here. Not me, not Jay, not Navan, not you. The agents write the code. The agents review the code. We write scenarios. We describe problems. We define what satisfaction looks like. But we don't touch the codebase."

"Justin, I spent three hours on that refactor. It's clean. It works. I ran the tests."

"I believe you. I looked at the diff. It's genuinely good work. And that's exactly the problem." Justin paused, choosing his words. "If I merge your PR, I've introduced human-authored code into a system that's designed to be entirely machine-generated. The agents can't reason about code they didn't write. They can't maintain it, refactor it, or evolve it the same way. It becomes a foreign body in the codebase."

Marcus set down his water bottle. "So what do I do with the logging problem?"

"You write a scenario that describes the problem. 'The logging middleware produces redundant structured output under these conditions. A satisfactory solution reduces noise by at least forty percent without losing diagnostic value.' Then you let the agents solve it."

"And if they solve it differently than I would?"

"They almost certainly will. That's fine. The scenario defines what good looks like. The path to good is the agents' problem."

Marcus stood there for a long moment. Justin could see him working through it—the sunk cost of three hours, the cognitive dissonance of being told his good code wasn't welcome. It was a lot to process.

"This is the weirdest job I've ever had," Marcus said finally.

"It's the weirdest job any of us have ever had," Justin agreed. "But it works. It works in a way that nothing else I've tried works. And the reason it works is that we don't make exceptions. Not even for good code. Especially not for good code."

Marcus picked up his water bottle. "I'll write the scenario tonight."

"Thank you."

The PR was closed without merge at 5:12 PM. No comments. No review. Just a quiet little red icon in the GitHub interface, marking the end of two hundred and six lines that would never run.

Kudos: 112

scenario_enjoyer 2025-09-03

"Especially not for good code." This is the line that made me put my phone down and stare at the ceiling for five minutes. The discipline required to reject GOOD work because it violates the principle... that's something else.

closed_without_merge 2025-09-04

That last paragraph is devastating. "Two hundred and six lines that would never run." I felt that in my chest. Poor Marcus. He'll get it eventually.

← Previous Work All Works Next Work →